Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add animationLoop.redraw() method. #897

Closed
5 tasks
donmccurdy opened this issue Feb 7, 2019 · 1 comment
Closed
5 tasks

Add animationLoop.redraw() method. #897

donmccurdy opened this issue Feb 7, 2019 · 1 comment

Comments

@donmccurdy
Copy link
Collaborator

Background

When using LumaGL (via DeckGL) in applications, it can be useful to synchronously cause LumaGL to draw outside of its normal animation loop. For example, Google Maps API has its own animation loop – which cannot be manually controlled – and when a DeckGL layer is used on top of the Maps API basemap, we would like to ensure that the DeckGL layer's rendering is synchronized with the basemap's. Because the map may have multiple layers or none at all, depending on application state, it seems preferable for Maps API to manage the animation loop, rather than DeckGL.

Per earlier discussion (visgl/deck.gl#2179 (comment)) I propose adding an animationLoop.redraw() method to support this.

One alternative would be to create an API through which DeckGL can be used without an animation loop entirely, manually calling some .draw() method as needed. That seems like a more invasive change, and introduces complexity when the layer itself contains time-based animation.

To Do List

  • Add label and assign to milestone
  • Coding
  • Doc update
  • Whats new update
  • Test
@donmccurdy
Copy link
Collaborator Author

Addressed by #896, thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant