You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the <MapGL> component clones it's children and adds the necessary props. This causes all props to be required as optional since they first get created once without the necessary props. To solve this, we can either:
This would require changes to the implementation of existing overlays. It also means we wont be able to use PureRenderMixin since it doesn't know about context. It's also seems to be discouraged to use context in React in general.
2.) Pass the overlays to a callback properly of the <MapGL> component.
This would cause changes to the usage of overlays but requires no changes to the overlays themselves. It also has the advantage of supporting PureRenderMixin.
The text was updated successfully, but these errors were encountered:
Currently, the
<MapGL>
component clones it's children and adds the necessary props. This causes all props to be required as optional since they first get created once without the necessary props. To solve this, we can either:1.) Use React's context feature.
This would require changes to the implementation of existing overlays. It also means we wont be able to use
PureRenderMixin
since it doesn't know aboutcontext
. It's also seems to be discouraged to use context in React in general.2.) Pass the overlays to a callback properly of the
<MapGL>
component.This would cause changes to the usage of overlays but requires no changes to the overlays themselves. It also has the advantage of supporting
PureRenderMixin
.The text was updated successfully, but these errors were encountered: