Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lookup with ask_matches = False doesn't return closest name #42

Open
keithotis opened this issue Feb 16, 2021 · 1 comment
Open

lookup with ask_matches = False doesn't return closest name #42

keithotis opened this issue Feb 16, 2021 · 1 comment

Comments

@keithotis
Copy link

when ask_matches = False the lookup function needs to sort the list like it does when it's true and the list is > 1:
matches.sort(key=lambda tup: tup[1])
@bellmatthewf
Copy link
Contributor

bellmatthewf commented Apr 13, 2021 •
edited

Addressed in PR here

@bellmatthewf bellmatthewf mentioned this issue Apr 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@keithotis @bellmatthewf