Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_box_scores() doesnt find any tables since yesterday #99

Open
my7hai opened this issue Jan 5, 2023 · 5 comments
Open

get_box_scores() doesnt find any tables since yesterday #99

my7hai opened this issue Jan 5, 2023 · 5 comments

Comments

@my7hai
Copy link

my7hai commented Jan 5, 2023

raw_df = pd.read_html(str(table))[0]
..
.
.
tables = self._parse_tables(self._build_doc(), self.match, self.attrs)

ValueError: No tables found

@JJnotJimmyJohn
Copy link
Contributor

Yeah I have to rewrite get_box_scores to scrape from pages like https://www.basketball-reference.com/boxscores/202301010DEN.html.

@my7hai
Copy link
Author

my7hai commented Jan 10, 2023

Yeah I have to rewrite get_box_scores to scrape from pages like https://www.basketball-reference.com/boxscores/202301010DEN.html.

will you? ive grown very used to this awesome tool =)

@christian-dalton
Copy link

When will this be fixed?

@JJnotJimmyJohn
Copy link
Contributor

When will this be fixed?

I thought it would be fixed by someone else by now. Kind of busy this week so I'll try fixing it next week if not fixed by then.

@JJnotJimmyJohn
Copy link
Contributor

JJnotJimmyJohn commented Sep 6, 2023

Hey friends! I just submitted a pull request to fix this error. I also developed "ADVANCED" stats mode.

@christian-dalton @my7hai Hopefully it's not too late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants