Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space between Home and About Section #28

Closed
ghost opened this issue Feb 8, 2021 · 2 comments · Fixed by #34
Closed

Space between Home and About Section #28

ghost opened this issue Feb 8, 2021 · 2 comments · Fixed by #34
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ghost
Copy link

ghost commented Feb 8, 2021

Deliverables:

  • Remove the extra space present between Home and About section(Reduce the space).

Screenshot of the bug
Capture
@ghost ghost added bug Something isn't working good first issue Good for newcomers labels Feb 8, 2021
@shakmg
Copy link

shakmg commented Feb 9, 2021

@urvashi-code1255 Hi, I've submitted a first open source PR for this issue, please take a look, thanks.

@ghost ghost linked a pull request Feb 11, 2021 that will close this issue
Fixed spacing issue between Home and About sections #34
Merged
@ghost ghost closed this as completed Feb 11, 2021
@shakmg
Copy link

shakmg commented Feb 17, 2021

@urvashi-code1255 Can you please help me understand as I can't see my contribution to this repo even though my changes have been merged in?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed spacing issue between Home and About sections shakmg/Awesome-JavaScript-Projects
1 participant
@shakmg