Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transpile to ES5 #745

Closed
stnwk opened this issue Feb 6, 2020 · 1 comment
Closed

Transpile to ES5 #745

stnwk opened this issue Feb 6, 2020 · 1 comment

Comments

@stnwk
Copy link

stnwk commented Feb 6, 2020

Hi :) Thank you for your work on this package!

Please re-consider this issue: #668

It is a major blocker and breaking-change that was released under a minor version upgrade on this package.

You stated transpile your dependencies just like everyone else does - unfortunately that is not true and creating a lot of problems in the JS ecosystem.

Some resources:

Because our app still has to support IE11, we are effectively prevented from upgrading packages that then use your debug package on a latest version, which breaks IE11 support although they did not release a major upgrade because this package did not do so. The only way we can get around is by transpiling our node_modules, which is not feasible for big packages and gets really cumbersome to manage exceptions at a larger scale.

Happy to discuss & help you understand this problem and the impact you and this package are having on the entire eco-system. I really hope you reconsider.

Sincerely,
Stefan

@Qix- Qix- closed this as completed Feb 6, 2020
@debug-js debug-js locked as spam and limited conversation to collaborators Feb 6, 2020
@Qix-
Copy link
Member

Qix- commented Feb 6, 2020

Sorry, no. It is no longer the belief that transpiling node_modules is a bad idea. The future is ES6 and beyond; IE11 is the last remaining browser that is supported that subsequently does not support ES6 at all. This is what babel is made for.

I'm not trying to be mean about this, but transpiling debug to ES5 for releases is only going to resolve your IE11 incompatibilities until you hit the next module that is distributed as ES6.

Plus, transpiling isn't going to work for every use-case, either. It's a very application-specific process that I can't make decisions about.

I'm 100% aware of the arguments from both sides of the arguments - I've been writing javascript for almost 15 years now (ES3) and have been in the node community since 0.10. The transpilation debate is over now; Babel is how things should be done, and with modern bundlers is trivial to configure to do so.

create-react-app is a bloated generator; I don't personally support its use. It is not our (package maintainers') jobs to pick up the slack where create-react-app chooses not to do something. You are more than welcome to eject your application and create a bundler if you need to support archaic browsers.

Alternatively, learn to mount your own react apps - it's really not that hard (parcel is an excellent tool for this).

As stated in the comment when creating an issue, this is a decision that will not change. You're welcome to create an issue at create-react-app if you feel they should add a transpilation step.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants