Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance local caching for "enabled" property (no-leak) #779

Closed
wants to merge 4 commits into from

Conversation

thewalkingmonty
Copy link

I initially overlooked @Qix- fix #740 to issue #678 and came up with almost the same solution, with just the difference the enabled property is managed in a slight different way that:

  • caches the status of the enabled property maintaining a stable performance when used in non dynamic context
  • do not change the way the enable function interacts with the enabled property

So I'm proposing my fix besides @Qix-'s one as it may add some little value.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 89.568% when pulling c3646d0 on thewalkingmonty:no-leak into 6087241 on visionmedia:no-leak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants