Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented full type support #84

Closed
wants to merge 4 commits into from

Conversation

genehallman
Copy link

Changed the parseTagTypes function to support all the tag types listed on https://developers.google.com/closure/compiler/docs/js-for-compiler#types

These commits modify the existing return type of parseTagTypes and so are not backwards compatible.

Tests included.

@thom4parisot
Copy link
Contributor

👍 great PR.

Do you plan to work on @typedef or more complex declaration?
Like @param {{ src: String|Array.<String>, dest: String }} taskData Blah blah blah?

@genehallman
Copy link
Author

Without testing anything I'm about to state:

@typedefs should "work", I think they'll get parsed into the tags array, with type data.

As for complex types, I've usually documented them jsdoc2 style:

/**
 * Does something
 * @param taskData {Object} A set of options
 * @param taskData.src {String | Array.} blah
 * @param taskData.dest {String} blah
 */

That should parse correctly.

@gionkunz
Copy link
Contributor

@oncletom , complex type declaration is possible with #136

@evindor
Copy link
Collaborator

evindor commented Nov 27, 2014

Seems like @gionkunz did this in #136

@evindor evindor closed this Nov 27, 2014
@thom4parisot
Copy link
Contributor

No worries, thanks @evindor for the review and @genehallman / @gionkunz for your contribution :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants