Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

deprecate Move.version #29

Open
yields opened this Issue Sep 28, 2013 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

yields commented Sep 28, 2013

No description provided.

Collaborator

axelpale commented May 9, 2015

May I ask why?

Personally I see greater pros than cons in having Move.version.

For example in studying the issue #72 I had to figure out why Example 1 works in public documentation but not in my local clone of 0.4.0. Without move.version I would had hard time to figure out that the public documentation uses version 0.3.2 and to deduct that the issue is caused between 0.3.2 -> 0.4.0.

A downside of having move.version is a slight maintenance overhead as the version needs to be updated manually to index.js, component.json and possibly in near future to package.json.

Another downside is its effect to filesize if we really want to be minimal there.

Therefore, because the aid for debugging, I propose move.version to stay.

Collaborator

axelpale commented May 9, 2015

It is bit ironic that now I found out that when the version has been bumped from 0.3.2 to 0.4.0, move.version was left intact in index.js. Therefore now we have no means to figure out whether the public docs uses 0.4.0 or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment