-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrections for IE10 flexbox #188
Conversation
+1 for this |
needs to be rebased first, other than that, it looks great. thanks @juriejan |
👍 |
1 similar comment
👍 |
IE 10 uses -ms-flex-item-align to align flex-items. From IE 11 the official align-self property is used.
Added one more fix (IE-10 equivalent of align-self) and rebased everything on your current master branch. |
thankyou @juriejan and @renehamburger |
Thanks for the good job! @juriejan @renehamburger |
👍 |
👍 for a npm update |
yeah, we really do need to bump the version... do you think this should be a major version bump? ... cause the gradients thing and this were both pretty big changes. |
Yes, I'd say this should be a major version bump here. |
done! ... bumped to |
display: vendor-value(box args, only: moz ms webkit) if box in flex-version | ||
display: vendor-value(arguments, only: webkit official) if flex in flex-version // overwrites old webkit | ||
if box in flex-version | ||
display: -ms-flexbox args |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems that we are lacking the -ms-inline-flexbox here?
Corrected 'flebox' utilities to play nice in IE10 using the following guides:
http://msdn.microsoft.com/en-us/library/ie/hh772069(v=vs.85).aspx
http://zomigi.com/blog/flexbox-syntax-for-ie-10/
As briefly discussed in #174