Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections for IE10 flexbox #188

Merged
merged 10 commits into from
Jul 22, 2013
Merged

Conversation

juriejan
Copy link
Contributor

@juriejan juriejan commented Jun 6, 2013

Corrected 'flebox' utilities to play nice in IE10 using the following guides:

http://msdn.microsoft.com/en-us/library/ie/hh772069(v=vs.85).aspx
http://zomigi.com/blog/flexbox-syntax-for-ie-10/

As briefly discussed in #174

@old9
Copy link
Contributor

old9 commented Jun 25, 2013

+1 for this

@notslang
Copy link
Collaborator

needs to be rebased first, other than that, it looks great. thanks @juriejan

@Pickachu
Copy link

👍

1 similar comment
@luccamordente
Copy link

👍

@renehamburger
Copy link
Contributor

Added one more fix (IE-10 equivalent of align-self) and rebased everything on your current master branch.

notslang added a commit that referenced this pull request Jul 22, 2013
@notslang notslang merged commit 3988814 into stylus:master Jul 22, 2013
@notslang
Copy link
Collaborator

thankyou @juriejan and @renehamburger

@Pickachu
Copy link

Thanks for the good job! @juriejan @renehamburger

@optikfluffel
Copy link
Contributor

👍

@old9
Copy link
Contributor

old9 commented Aug 7, 2013

👍 for a npm update

@notslang
Copy link
Collaborator

notslang commented Aug 7, 2013

yeah, we really do need to bump the version... do you think this should be a major version bump? ... cause the gradients thing and this were both pretty big changes.

@kizu
Copy link
Member

kizu commented Aug 7, 2013

Yes, I'd say this should be a major version bump here.

@notslang
Copy link
Collaborator

done! ... bumped to 1.0.0

display: vendor-value(box args, only: moz ms webkit) if box in flex-version
display: vendor-value(arguments, only: webkit official) if flex in flex-version // overwrites old webkit
if box in flex-version
display: -ms-flexbox args
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems that we are lacking the -ms-inline-flexbox here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants