Broken querystring after qs.stringify

[kof]

I have the following url

http://git.ozlabs.org/?p=yaboot.git;a=rss;f=second/file.c;opt=--no-merges

parsed output of it is

{ protocol: 'http:',
slashes: true,
auth: null,
host: 'git.ozlabs.org',
port: null,
hostname: 'git.ozlabs.org',
hash: null,
search: '?p=yaboot.git;a=rss;f=second/file.c;opt=--no-merges',
query: { p: 'yaboot.git;a=rss;f=second/file.c;opt=--no-merges' },
pathname: '/',
path: '/?p=yaboot.git;a=rss;f=second/file.c;opt=--no-merges',
href: 'http://git.ozlabs.org/?p=yaboot.git;a=rss;f=second/file.c;opt=--no-merges' }

[kof]

If I change pathname to path, it breaks 3 tests.

[kof]

1. req.query(String) should work with url query-string:

  Uncaught AssertionError: expected { name: [ 'tobi', 'tobi' ], age: '2' } to equal { name: 'tobi', age: '2' }
  + expected - actual

   {
     "age": "2",
  +  "name": "tobi"
  -  "name": [
  -    "tobi",
  -    "tobi"
  -  ]
   }

2. req.query(Object) should append to the original query-string:

  Uncaught AssertionError: expected { name: [ 'tobi', 'tobi' ], order: 'asc' } to equal { name: 'tobi', order: 'asc' }
  + expected - actual

   {
  +  "name": "tobi",
  -  "name": [
  -    "tobi",
  -    "tobi"
  -  ],
     "order": "asc"
   }

3. req.query(Object) should retain the original query-string:

  Uncaught AssertionError: expected { name: [ 'tobi', 'tobi' ] } to equal { name: 'tobi' }
  + expected - actual

   {
  +  "name": "tobi"
  -  "name": [
  -    "tobi",
  -    "tobi"
  -  ]
   }

[kof]

Oh thats complicated to track down. So at the end the path looks like

/?p=yaboot.git%3Ba%3Drss%3Bf%3Dsecond%2Ffile.c%3Bopt%3D--no-merges

[kof]

Finally understood the problem.

qs.stringify encodes the url and in this case it breaks things, here:

try {
var querystring = qs.stringify(this.qs);
req.path += querystring.length
? (~req.path.indexOf('?') ? '&' : '?') + querystring
: '';
} catch (e) {
return this.callback(e);
}

[kof]

No idea where to fix that correctly

[ikokostya]

Before commit 629bf9b any string passed in Request#query just appends to querystring without encoding.

[defunctzombie]

Is there an issue here? Is this about the client version or the node version?

[defunctzombie]

Closing this for no response. If this is still broken (sounds likely) can we make a simple explanation of the issue and failing test. The current issue is hard to follow :)