Added prefix option for agents #465
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should be closed in favor of #453 |
|
These two PRs provide different features |
|
@Thann yes you are right. |
| @@ -815,6 +815,17 @@ describe('request.agent(app)', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('request.agent(app, {prefix})', function() { | |||
| it('should apply prefix', function(done) { | |||
There was a problem hiding this comment.
could you provide a successful test (e.g. with 200 status code) as well?
There was a problem hiding this comment.
Oh yeah, I can't believe I didn't do that already!
Pull Request Test Coverage Report for Build 407
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 407
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents users from having to repeat themselves in tests, by setting a common prefix for all routes.