Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visit_utils.engine.open(method=slurm) --> use SLURM_NPROCS #19435

Open
cyrush opened this issue Mar 28, 2024 · 0 comments
Open

visit_utils.engine.open(method=slurm) --> use SLURM_NPROCS #19435

cyrush opened this issue Mar 28, 2024 · 0 comments
Assignees
@cyrush
Labels
bug Something isn't working impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) likelihood medium Neither low nor high likelihood reviewed Issue has been reviewed and labeled by a developer
Milestone
3.4.2

Comments

@cyrush
Copy link
Member

cyrush commented Mar 28, 2024

Describe the bug

https://visit-sphinx-github-user-manual.readthedocs.io/en/develop/python_scripting/visit_utils.html?highlight=engine.open#visit_utils.engine.open

We should use slurm nprocs (direclty what was asked for) instead of calc of SLURM_CPUS_ON_NODE SLURM_JOB_NUM_NODES

visit/src/visitpy/visit_utils/src/engine.py

Line 84 in 33cdcb0

elif kwargs["method"] == "slurm":

@cyrush cyrush added bug Something isn't working likelihood medium Neither low nor high likelihood impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) labels Mar 28, 2024
@cyrush cyrush added this to the 3.4.2 milestone Apr 10, 2024
@cyrush cyrush self-assigned this May 23, 2024
@cyrush cyrush added the reviewed Issue has been reviewed and labeled by a developer label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cyrush cyrush

Labels
bug Something isn't working impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) likelihood medium Neither low nor high likelihood reviewed Issue has been reviewed and labeled by a developer
Projects
None yet
Milestone
3.4.2
Development

No branches or pull requests
1 participant
@cyrush