Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix xdmf build issues in build_visit #2688

Closed
aowen87 opened this issue Feb 27, 2019 · 0 comments
Closed

fix xdmf build issues in build_visit #2688

aowen87 opened this issue Feb 27, 2019 · 0 comments
Assignees
Labels
bug Something isn't working impact low Productivity trivially degraded (easily mitigated bug) or improved (enhancment) likelihood medium Neither low nor high likelihood reviewed Issue has been reviewed and labeled by a developer
Milestone

Comments

@aowen87
Copy link
Contributor

aowen87 commented Feb 27, 2019

Rick Angelini ran into several issues. In summary... For some reason, Xdmf builds its library(s) in a 'bin' dir instead of a 'lib' dir. Its probably cosmetic but lets check that out bv_xdmf doesn't set LIBXML2_LIBRARY variable name quite right. Its missing the :FILEPATH qualifier. That may create problems when Xdmf build tries to find the libxml2 library in our VTK insallation XDMF_SYSTEM_LIBXML2 setting? What should it be. I think it should be set to OFF and we should be using libxml2 in VTK, as the other variables we define appear to be trying to do that. However, examining Xdmf's CMakeList.txt file suggests that SYSTEM may have a different interpretation there. XDMF_SYSTEM_LIBZ should be adjusted to either be YES or to be NO and instead use whatever ZLIB build_visit has installed (and definitely not vtk's zlib as per #2679)

-----------------------REDMINE MIGRATION-----------------------
This ticket was migrated from Redmine. As such, not all
information was able to be captured in the transition. Below is
a complete record of the original redmine ticket.

Ticket number: 2688
Status: Resolved
Project: VisIt
Tracker: Bug
Priority: Normal
Subject: fix xdmf build issues in build_visit
Assigned to: Kathleen Biagas
Category: -
Target version: 2.12.0
Author: Mark Miller
Start: 10/13/2016
Due date:
% Done: 0%
Estimated time:
Created: 10/13/2016 04:08 pm
Updated: 10/25/2016 08:13 pm
Likelihood: 3 - Occasional
Severity: 2 - Minor Irritation
Found in version: 2.10.0
Impact:
Expected Use:
OS: All
Support Group: Any
Description:
Rick Angelini ran into several issues. In summary... For some reason, Xdmf builds its library(s) in a 'bin' dir instead of a 'lib' dir. Its probably cosmetic but lets check that out bv_xdmf doesn't set LIBXML2_LIBRARY variable name quite right. Its missing the :FILEPATH qualifier. That may create problems when Xdmf build tries to find the libxml2 library in our VTK insallation XDMF_SYSTEM_LIBXML2 setting? What should it be. I think it should be set to OFF and we should be using libxml2 in VTK, as the other variables we define appear to be trying to do that. However, examining Xdmf's CMakeList.txt file suggests that SYSTEM may have a different interpretation there. XDMF_SYSTEM_LIBZ should be adjusted to either be YES or to be NO and instead use whatever ZLIB build_visit has installed (and definitely not vtk's zlib as per #2679)

Comments:
Re #1: Looks like the .so's are placed in 'bin' during build, but are installed to 'lib'. It's controlled by XDMF's root CMakeLists.txt file, where this is defined:SET (LIBRARY_OUTPUT_PATH ${Xdmf_BINARY_DIR}/bin/ CACHE PATH "Single output directory for building all libraries.")Since the Xdmf library we currently use will soon be updated, I think we can safely ignore this for now.#2, #3 done.#4, should be handled by #2679.

@aowen87 aowen87 added this to the 2.12.0 milestone Feb 27, 2019
@aowen87 aowen87 added bug Something isn't working likelihood medium Neither low nor high likelihood reviewed Issue has been reviewed and labeled by a developer impact low Productivity trivially degraded (easily mitigated bug) or improved (enhancment) labels Feb 27, 2019
@aowen87 aowen87 closed this as completed Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working impact low Productivity trivially degraded (easily mitigated bug) or improved (enhancment) likelihood medium Neither low nor high likelihood reviewed Issue has been reviewed and labeled by a developer
Projects
None yet
Development

No branches or pull requests

2 participants