fix(rollup-conf): styles dir location #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to recent breaking changes in Rollup PostCSS plugin that I completely missed the styles dir has moved from the root to the bundle files and is now 4 times in the packages (4 copies of the same thing). This is not how it is documented and was never announced to the public as a breaking change. This commit reverses it to the way it used to be prior to the update. It also officially drops support for Rollup PostCSS plugin (dev dep in our projects) version 2 since the way paths are interpreted is different from the up to date version 3.
yotamberk
approved these changes
May 16, 2020
|
🎉 This PR is included in version 2.2.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to recent breaking changes in Rollup PostCSS plugin that I completely missed the styles dir has moved from the root to the bundle files and is now 4 times in the packages (4 copies of the same thing). This is not how it is documented and was never announced to the public as a breaking change. This commit reverses it to the way it used to be prior to the update. It also officially drops support for Rollup PostCSS plugin (dev dep in our projects) version 2 since the way paths are interpreted is different from the up to date version 3.