feat(ci-utils): add a command for CI stuff we use in multiple repos #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment it's only for installing dependencies.
yotamberk
approved these changes
Aug 8, 2020
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment it's only for installing dependencies, but it's modular so adding anything new will be as simple as adding a new command to
src/ci-utils/index.ts. This will come in handy especially if we decide to implement E2E interop tests (which seems doable to me if #272 gets merged) so that I won't have to copy paste the sameapt-install …commands all over the place and also manually copy paste the same fix everywhere in case the dependencies change at some point (which is quite likely because CircleCI is rolling out “next-generation” Ubuntu based images with fewer preinstalled packages, they may discontinue the chunkier Debian based ones we've been using so far).I also removed some dependencies that seem unnecessary (it runs just fine without them), I'm not sure anymore where I got the list originally, it probably lists a lot of dependencies that are installed anyway or maybe dependencies of dependencies, dependencies for functionality we don't use etc.
PS: CircleCI has orbs to achieve this. However I have no idea how to create an orb whereas this was easy for me to do, it's easy to use and CI provider agnostic, if we decide to switch at any point in the future.