Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): use common header and Babel preset #237

Merged
merged 1 commit into from
Dec 30, 2019
Merged

fix(build): use common header and Babel preset #237

merged 1 commit into from
Dec 30, 2019

Conversation

Thomaash
Copy link
Member

See visjs/vis-dev-utils#5.

This also removes prototype pollution associated with the previously used useBuiltIns: true see visjs/vis-network#191.

@Thomaash
fix(build): use common header and Babel preset
9aaab20 
See visjs/vis-dev-utils#5.

This also removes prototype pollution associated with the previously
used `useBuiltIns: true`.
@Thomaash Thomaash requested a review from a team December 30, 2019 14:04
@Thomaash
Copy link
Member Author

Oh, one more thing. The generate-examples-index from Vis Dev Utils returns nonzero status code for solid color screenshots since 1.1.0. In other words if nothing is rendered onto the canvas it will fail CI tests.

@yotamberk yotamberk merged commit 61ad7cf into master Dec 30, 2019
@yotamberk yotamberk deleted the use-shared-header-and-babel-preset branch December 30, 2019 19:15
@vis-bot
Copy link
Collaborator

vis-bot commented Dec 30, 2019

🎉 This PR is included in version 6.3.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yotamberk yotamberk yotamberk approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Thomaash @vis-bot @yotamberk