Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functional tests #33

Open
almarklein opened this issue Jul 28, 2021 · 5 comments
Open

Add functional tests #33

almarklein opened this issue Jul 28, 2021 · 5 comments
Labels
good first issue Good for newcomers

Comments

@almarklein
Copy link
Member

Would be nice to have some tests using this in an actual notebook and simulating user interaction. I don't consider this super-higher priority right now.

Marked this as a good first issue. By which I mean it's great for someone who wants to contribute to this project, but who does have experience with Jupyter, ipywidgets, and testing.

@almarklein almarklein added the good first issue Good for newcomers label Jul 28, 2021
@Himanxu1
Copy link

Hello, I am a beginner and I want to contribute to it.

@djhoese
Copy link
Member

djhoese commented Jul 29, 2021

Hi @Himanxu1! Welcome. This project is very very very new so we're not exactly sure what needs work. I'm not sure if @almarklein knows how, but I have no idea how to implement the tests he's hoping for here. We use pytest for our testing in this package, but do you know of any way to run tests with a jupyter notebook and test user interaction in some way? That will be the big hurdle with this issue.

Any help is appreciated. Thanks.

@almarklein
Copy link
Member Author

I also have no idea right now, but I'm sure we can learn a lot from how projects like ipywidgets and some of its popular subclass projects (e.g. ipyleaflet, ipyvolume) do it.

@almarklein
Copy link
Member Author

Thanks for your interest, by the way! I did not expect new contributors so quickly :)

@Himanxu1
Copy link

Thanks for your advice. I am just new to open source and want to Contribute !
I have intermediate knowledge of java >

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants