Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests on macOS 12.3, arm64 and emulated x86, pyqt5 #2335

Open
psobolewskiPhD opened this issue May 25, 2022 · 3 comments
Open

Tests on macOS 12.3, arm64 and emulated x86, pyqt5 #2335

psobolewskiPhD opened this issue May 25, 2022 · 3 comments

Comments

@psobolewskiPhD
Copy link
Contributor

psobolewskiPhD commented May 25, 2022

Based on the discussion here: #2324
I ran the full vispy tests on my macOS 12.3 M1 (apple silicon arm64).
Here's in a native arm64 python 3.9 env:
Edit: this is actually main

=========================== short test summary info ============================
FAILED app/tests/test_canvas.py::test_canvas_render[blend_func1] - assert False
FAILED io/tests/test_io.py::test_meshio - ValueError: write_mesh does not und...
FAILED util/tests/test_import.py::test_import_vispy_no_pyopengl - AssertionEr...
FAILED visuals/tests/test_image.py::test_image_nan_single_band[None] - Assert...
FAILED visuals/tests/test_image.py::test_image_nan_single_band[auto] - Assert...
FAILED visuals/tests/test_image.py::test_image_nan_rgb[None-3] - AssertionErr...
FAILED visuals/tests/test_image.py::test_image_nan_rgb[None-4] - AssertionErr...
FAILED visuals/tests/test_image.py::test_image_nan_rgb[auto-3] - AssertionErr...
FAILED visuals/tests/test_image.py::test_image_nan_rgb[auto-4] - AssertionErr...
FAILED visuals/tests/test_image.py::test_image_interpolation - assert False
FAILED visuals/tests/test_volume.py::test_plane_depth - assert False
FAILED visuals/tests/test_windbarb.py::test_windbarb_draw - AssertionError
FAILED scene/cameras/tests/test_perspective.py::test_panzoom_center - Asserti...
= 13 failed, 852 passed, 7 skipped, 6 xfailed, 99 warnings in 172.01s (0:02:52) =

Full report here: https://gist.github.com/psobolewskiPhD/a7eb636e8cbcc32b574065a386aec905

Edit: here is 0.10.0 live arm64 python 3.9:

=========================== short test summary info ============================
FAILED app/tests/test_canvas.py::test_canvas_render[blend_func1] - assert False
FAILED app/tests/test_simultaneous.py::test_multiple_canvases - AssertionError: 
FAILED io/tests/test_io.py::test_meshio - ValueError: write_mesh does not und...
FAILED scene/cameras/tests/test_perspective.py::test_panzoom_center - Asserti...
FAILED util/tests/test_import.py::test_import_vispy_no_pyopengl - AssertionEr...
FAILED visuals/tests/test_image.py::test_image_nan_single_band[None] - Assert...
FAILED visuals/tests/test_image.py::test_image_nan_single_band[auto] - Assert...
FAILED visuals/tests/test_image.py::test_image_nan_rgb[None-3] - AssertionErr...
FAILED visuals/tests/test_image.py::test_image_nan_rgb[None-4] - AssertionErr...
FAILED visuals/tests/test_image.py::test_image_nan_rgb[auto-3] - AssertionErr...
FAILED visuals/tests/test_image.py::test_image_nan_rgb[auto-4] - AssertionErr...
FAILED visuals/tests/test_volume.py::test_plane_depth - assert False
FAILED visuals/tests/test_windbarb.py::test_windbarb_draw - AssertionError
===== 13 failed, 850 passed, 7 skipped, 6 xfailed, 954 warnings in 55.15s ======

Full report
https://gist.github.com/psobolewskiPhD/c3566e2b12e7f12b97c0fa99b6de4a86

here's a x86 python 3.9 run in emulation (rosetta2)

=========================== short test summary info ============================
FAILED app/tests/test_canvas.py::test_canvas_render[blend_func1] - assert False
FAILED io/tests/test_io.py::test_meshio - ValueError: write_mesh does not und...
FAILED scene/cameras/tests/test_perspective.py::test_panzoom_center - Asserti...
FAILED util/tests/test_import.py::test_import_vispy_no_pyopengl - AssertionEr...
FAILED visuals/tests/test_image.py::test_image_nan_single_band[None] - Assert...
FAILED visuals/tests/test_image.py::test_image_nan_single_band[auto] - Assert...
FAILED visuals/tests/test_image.py::test_image_nan_rgb[None-3] - AssertionErr...
FAILED visuals/tests/test_image.py::test_image_nan_rgb[None-4] - AssertionErr...
FAILED visuals/tests/test_image.py::test_image_nan_rgb[auto-3] - AssertionErr...
FAILED visuals/tests/test_image.py::test_image_nan_rgb[auto-4] - AssertionErr...
FAILED visuals/tests/test_volume.py::test_plane_depth - assert False
FAILED visuals/tests/test_windbarb.py::test_windbarb_draw - AssertionError
===== 12 failed, 851 passed, 7 skipped, 6 xfailed, 954 warnings in 58.39s ======

Full report here: https://gist.github.com/psobolewskiPhD/007950d1734ae0574ce9ca09c5d1d09a

@psobolewskiPhD
Copy link
Contributor Author

OK, the test_meshio tests:
FAILED io/tests/test_io.py::test_meshio - ValueError: write_mesh does not und...
were due to not having meshio installed.
After installing they pass.

Also, if I manually run pytest on vispy/app/tests/test_simultaneous.py it passes (arm64 env).
So then arm64 and x86 are the same.

@brisvag
Copy link
Collaborator

brisvag commented Jun 21, 2022

Do I understand correctly here that this can be closed?

@psobolewskiPhD
Copy link
Contributor Author

@djhoese Asked me to run the full tests on macOS, related to the test failure I observed in one of the sub-sections.
One thing that is positive is that emulated x86 and arm64 makes no difference. But it would be interesting to see a native Intel mac run the suite.
I'm not sure how addressable or how important it is to address these.
🤷‍♂️

@psobolewskiPhD psobolewskiPhD changed the title Tests on macOS 12.3, arm64 and emulated x86 Tests on macOS 12.3, arm64 and emulated x86, pyqt5 Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants