Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separation of patterns by 'ownership' #179

Closed
sturobson opened this issue Jan 23, 2019 · 2 comments
Closed

separation of patterns by 'ownership' #179

sturobson opened this issue Jan 23, 2019 · 2 comments
Milestone

Comments

@sturobson
Copy link

I think it might be cleaner to move EMBL specific patterns to their own 'space' in the layout of patterns?

I think the best way to do this in the UI is to duplicate the layout with blocks/containers/pages/deprecated

We cannot do this in the folder structure as it'd be a pain for lerna etc.

I think we should be able to do this with the way you have created the lists in the Fractal UI.

Next step is for me to try this - if it works - I'll raise a PR.

@khawkins98
Copy link
Contributor

Copying a comment over from the above PR:

ties in with the need to document our user types/need (#127)

That is:

  1. We have EMBL site builders that won't much care if a pattern is "VF block" or "EMBL block"
  2. We have distinctly non-EMBL users that want to avoid all EMBL specific stuff

Ideally we could do something like:

  1. If building for EMBL (dev.beta.embl.org/../dev-docs/), then show EMBL patterns
  2. If building generic VF (visual-framework.github.io/vf-core/), then hide EMBL patterns

But that has implications beyond just showing the patterns but also which patterns are used and > what's in vf-core/index.scss

As a mid-term step, thought is to use the above PR (splitting out patterns by type) for alpha.2 and then revisit a more holistic solution for alpha.3

@khawkins98
Copy link
Contributor

I think this has been largely addressed and it's a general thing we're working on. Being bold and closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants