Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORE - add Visual Regression Testing #31

Closed
sturobson opened this issue Nov 13, 2018 · 2 comments
Closed

CHORE - add Visual Regression Testing #31

sturobson opened this issue Nov 13, 2018 · 2 comments

Comments

@sturobson
Copy link

We need to make sure we start adding visual regression tests so that we confidently update patch, minor, and breaking changes.

As we will also be hosting a CDN version of the styles.css and scripts.js file that will depend on the file path altering when we make a major version change we need to include VRTs as part of the develop and/or build step(s).

There are several resources for this, both paid and completely open-source. I have used [BackstopJS[(https://garris.github.io/BackstopJS/) previously.

Is this something that can be part of the CI build?

@khawkins98
Copy link
Contributor

Just leaving a note, in addition to BackstopJS there's also Percy — I think you've previously mentioned it?

@sturobson
Copy link
Author

Closing because of #376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants