Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Makefile to include all makefiles in subdirectories #342

Closed
ThomasSanson opened this issue May 24, 2023 · 0 comments · Fixed by #355
Closed

Refactor Makefile to include all makefiles in subdirectories #342

ThomasSanson opened this issue May 24, 2023 · 0 comments · Fixed by #355

Comments

@ThomasSanson
Copy link
Sponsor Contributor

Hello Team,

During a routine review of our Makefile, I noticed that we're manually adding makefiles from the subdirectories. This method could potentially reduce our code maintainability, especially as our project grows and more makefiles are added to subdirectories.

To improve this, I propose a refactoring of the Makefile to use the wildcard function. This function will automatically include all makefiles in the subdirectories, meaning we will not have to modify the Makefile each time a new makefile is added.

Here is the proposed change:

-include $(addsuffix /*.mak, $(shell find .config/make -type d))

This new line will find all directories under .config/make and include any .mak files within them.

This change significantly improves maintainability and streamlines our project structure. I would appreciate your thoughts on this. If there are no objections, I will proceed with this refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant