Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap Modal Not Supported ? #4

Closed
shewitt opened this issue Nov 20, 2012 · 6 comments
Closed

Bootstrap Modal Not Supported ? #4

shewitt opened this issue Nov 20, 2012 · 6 comments
Labels

Comments

@shewitt
Copy link

shewitt commented Nov 20, 2012

Firstly, great job with this library, I love how it integrates into Bootstrap (almost) perfectly.

I can't seem to get this to work in a Bootstrap modal though. As a standalone page it works perfectly, but when using Twitter-Bootstrap's href method so it's loaded into the .modal-body using .load(), although the emptytext shows up, clicking an element has no effect.

Has it been tested in a modal ? Could I be doing something wrong ? Seems unlikely as it works as expected when I load it as a full standalone page.

@vitalets
Copy link
Owner

hi, I did not test it inside bootstrap modal.
I think you should apply $().editable() in shown event handler of modal.
It would be usefull to have jsfiddle with such example. thx!

@shewitt
Copy link
Author

shewitt commented Nov 21, 2012

I've made a simplified page now, and I think the x-editable popover is coming up behind the modal, I just couldn't see that on the previous page I was working with.

I'll post a jsfiddle example for you shortly.

@shewitt
Copy link
Author

shewitt commented Nov 21, 2012

Well, here's the jsfiddle example, which actually works although the popover positioning is out of whack;

http://jsfiddle.net/shewitt/3jdd4/

This same code didn't work when I ran it locally, but I was linking to local Bootstrap and Editable libs and I'm remote linking in jsfiddle. I've changed to the same remote libs in my local example now and it actually works, except for the popover positioning. I guess there's something off in the local libraries I'm using so I'll go investigate that.

@PhilETaylor
Copy link

Im also having this - debugging now :)

@PhilETaylor
Copy link

This popover positioning is caused in BS v2.2.2 with line 5159

.modal-body {
position: relative;
.....
}

This was added in BS v2.2.2 and causes the problem where the popover displays under the modal-header - this is a pain and I cannot work out how to fix other than removing that line from the bootstrap.css

@PhilETaylor
Copy link

ok reference for why this was changed in BS 2.2.2. is here twbs/bootstrap#6097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants