Authentication AND/OR operators #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 11, 2021 01:31
That closes #196. After merging this will be possible: @api.get( "/", auth=(Auth1() & Auth2()) | Auth3()), ) def f(request): pass What I don't like at this moment: * AuthBase.__call__ now is not abstractmethod, I used it for recursive descent. The previous method is called "callable" and it's not the best name. * Swagger docs is not built for operators. Must be something like this: https://swagger.io/docs/specification/authentication/#multiple * Django-ninja docs aren't yet written. * No clear error messages when trying to pair with "just callable".
|
Note: it's impossible to unite |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That closes #196.
After merging this will be possible:
What I don't like at this moment (marked lines are solved):
AuthBase.__call__now is not abstractmethod, I used it for recursive descent. The previous method is renamed to "callable" and it's not the best name.Swagger docs aren't built for operators. Must be something like this: https://swagger.io/docs/specification/authentication/#multiple
No clear error messages when trying to pair with "just callable".
Django-ninja docs aren't yet written.
The PR is in progress. Comments are welcome!