REST implementation of the Django authentication

[laith43d]

Hi,

This is not an issue, but rather a proposal.

I came by Django-Ninja a few days ago while surfing the Internet. This is beyond great, I would love to contribute.

An essential feature IMHO is to develop a REST implementation of the Django authentication system with Ninja instead of DRF. I have used Djoser before, which exactly that but implemented with DRF.

Is that in your plans? What can I do to help?

[vitalik]

Hi @laith43d
Thank you for trying django-ninnja

Well I thought about this, and I think this best lands into a separate plug-able app

you can basically implement a a router in external python package like:

# mydjoser/router.py
from ninja import Router


router = Router()

@api.get("/users/"):
def users(request):
   ...
@api.get("/users/me/"):
def me(request):
   ...

.. and so on...

and then it can be plugged to any app like:

api = NinjaAPI()

api.add_router("", mydjoser.router.router)

[laith43d]

Thanks, @vitalik

I have already started working on it, however, I have one last question, is Django-Ninja considered production-ready (in terms of stability), have you tested it in a production environment?

I am asking so I can convince my colleagues comfortably.

[vitalik]

Hi @laith43d
Yes, Django Ninja is used in multiple production applications already
(in fact a lot of security already done on Django core side)

[budlight]

@vitalik Are you aware of any currently active extensions to django-ninja? I feel like authentication is a super obvious one. I am writing my own for one time passwords right now and wouldn't mind structuring it in such a way to maybe make it part of a larger project in the future.

[vitalik]

Hi @budlight
no, currently I'm not aware of wide used public plugins

so if you have something to share let me know

[femiir]

Hi @laith43d Thank you for trying django-ninnja

Well I thought about this, and I think this best lands into a separate plug-able app

you can basically implement a a router in external python package like:

# mydjoser/router.py
from ninja import Router


router = Router()

@api.get("/users/"):
def users(request):
   ...
@api.get("/users/me/"):
def me(request):
   ...

.. and so on...

and then it can be plugged to any app like:

api = NinjaAPI()

api.add_router("", mydjoser.router.router)

are you saying directly djoser will not work or I pip install djoser then write a router to all djosers endpoints

[baseplate-admin]

are you saying directly djoser will not work

Yes djoser will not work automatically ( as far as i know )

I pip install djoser then write a router to all djosers endpoints

Yes you have to do this if you want to use djoser

[femiir]

well I will just write my logic once and always use it...as a boiler template for future projects as I always end up inheriting and customising things in def always