Allow reversing URLs with multiple operations. #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A pretty glaring shortcoming is that it is impossible to reverse URLs
that have been registered with same path, but different operations.
Using the same path for different operations is a pretty common pattern.
It is even used throughout Ninja's documentation.
@router.get("/{identifier}")
def detail(request, identifier: str):
return "ok"
@router.put("/{identifier}")
def update(request, identifier: str, data: Policy):
return "ok"
The above is perfectly valid, but reversing `update` using
`django.urls.reverse()` will result in a `NoReverseMatch` error.
This commit is an attempt at solving the issue. N.B. I am not familiar
with the internals of Ninja. This is just an experiment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pretty glaring shortcoming is that it is impossible to reverse URLs that have been registered with same path, but different operations.
Using the same path for different operations is a pretty common pattern. It is even used throughout Ninja's documentation.
The above is perfectly valid, but reversing
updateusingdjango.urls.reverse()will result in aNoReverseMatcherror.This commit is an attempt at solving the issue. N.B. I am not familiar with the internals of Ninja.