Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI issue #884

Closed
vitaly-t opened this issue Jun 1, 2023 · 3 comments
Closed

CI issue #884

vitaly-t opened this issue Jun 1, 2023 · 3 comments
Assignees
Labels

Comments

@vitaly-t
Copy link
Owner

vitaly-t commented Jun 1, 2023

GitHub Actions started showing problems recently, with the following error:

Connection for invalid connection must report the right error
   Message:
     Expected 'getaddrinfo EAI_AGAIN base' to contain 'password authentication failed for user'.
   Stacktrace:
=============================================================================
Writing coverage object [/home/runner/work/pg-promise/pg-promise/coverage/coverage.json]
     Error: Expected 'getaddrinfo EAI_AGAIN base' to contain 'password authentication failed for user'.
    at jasmine.Spec.<anonymous> (/home/runner/work/pg-promise/pg-promise/test/db.spec.js:264:43)
    at listOnTimeout (internal/timers.js:557:[17](https://github.com/vitaly-t/pg-promise/actions/runs/5098248657/jobs/9255178557#step:8:18))
    at processTimers (internal/timers.js:500:7)

This error has nothing to do with the project itself, it just appeared on its own, and relates to CI.

Need help finding the cause and fixing it. Any help is welcome!


@dplewis You originally integrated CI to this project, so maybe you know how to fix this?

@vitaly-t vitaly-t self-assigned this Jun 1, 2023
@thezanke
Copy link

thezanke commented Jun 29, 2023

This appears to be an error being caused by a test in db.spec.js. When pgp('blah-blah').connect() gets called, it's attempting to make a network connection. The test does expect there to be an error but not the error it's seeing; so you're seeing it as a matcher fail. The error the test expects to receive is one containing the text about "password authentication failure" but instead it's getting the "EAI_AGAIN" error, which is a DNS error in my experience.

Does this happen every time it runs or just intermittently?

@dplewis
Copy link
Contributor

dplewis commented Jul 23, 2023

@vitaly-t Can you try to rerun the CI a few times to see if this issue still exists?

@vitaly-t
Copy link
Owner Author

Thank you everybody for your help, the issue is now resolved, and a new release 11.5.1 has been published.

The issue was, as @thezanke pointed, in a broken test, which weirdly, started failing for reasons outside this library. I had to amend an old test, in order to make it pass again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants