Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event ready cause a bluebird warning #18

Closed
absolux opened this issue Jun 24, 2016 · 2 comments
Closed

event ready cause a bluebird warning #18

absolux opened this issue Jun 24, 2016 · 2 comments
Milestone
v0.8

Comments

@absolux
Copy link
Member

absolux commented Jun 24, 2016 •
edited

Emitting the ready event in the constructor, cause in some situation, eager loading many-to-many relationships, a bluebird warning

Warning: a promise was created in a handler but was not returned from it

Also, the promise rejections cannot be handled, because this event is automatically called from the constructor
@absolux
Copy link
Member Author

absolux commented Jun 24, 2016

removing the ready event solves the issue.

@absolux absolux added this to the v0.8 milestone Aug 11, 2016
@absolux
Copy link
Member Author

absolux commented Sep 7, 2016 •
edited

The event ready was deleted since v0.8.0

@absolux absolux closed this as completed Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.8
Development

No branches or pull requests
1 participant
@absolux