Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger default scroll event for other plugin integration #26

Closed
jeanduplessis opened this issue Nov 23, 2010 · 4 comments
Closed

Trigger default scroll event for other plugin integration #26

jeanduplessis opened this issue Nov 23, 2010 · 4 comments

Comments

@jeanduplessis
Copy link

I am trying to use jScrollPane with an infinite scroll plugin which binds to the scroll event, however jScrollPane doesn't trigger the scroll event.

I can modify the infiinite scroll plugin but would prefer to use it as is to be able to easily upgrade to another version without having to modify it the whole time.

Is there a specific reason for not triggering scroll?

@jeanduplessis
Copy link
Author

Ok I was able to manually trigger the scroll event by hooking into the jsp-scroll-y event.

e.bind( 'jsp-scroll-y', function(){
  $(this).trigger( 'scroll' );
});

However unless there's a specific reason, it would still be nice for the plugin to trigger it itself.

@vitch
Copy link
Owner

vitch commented Nov 23, 2010

I don't see any reason for the plugin to not trigger the scroll event itself. I wanted to dispatch custom events with more information (the jsp-scroll-x and jsp-scroll-y events that you found) but that isn't any reason to not also dispatch a normal scroll event... I will add it in when I next have the plugin code open - thanks for the suggestion :)

@vitch
Copy link
Owner

vitch commented Jan 29, 2011

Fixed in cd5fe9c :)

@jeanduplessis
Copy link
Author

Awesome - and thanks for your continued dev on this plugin!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants