Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated sharp dependency version #46

Open
EKliptus opened this issue May 18, 2024 · 1 comment
Open

Outdated sharp dependency version #46

EKliptus opened this issue May 18, 2024 · 1 comment

Comments

@EKliptus
Copy link

EKliptus commented May 18, 2024

@vite-pwa/assets-generator use an outdated version of sharp (v0.32.6)

With AstroPWA integration it cause a fatal issue when use :

  • AstroPWA pwaAssets integration
    and
  • Astro assets:image Image tag for optimization

Astro use an up-to-date version of sharp v0.33.4

See here for detail : withastro/astro#9345 (comment)

Please, is it possible to update sharp dependency to ^0.33.4 ?

Thanks

devDependencies:
@astrojs/tailwind 5.1.0
└─┬ astro 4.8.6 peer
  └── sharp 0.33.4
@vite-pwa/assets-generator 0.2.4
├── sharp 0.32.6
└─┬ sharp-ico 0.1.5
  └── sharp 0.33.4
@vite-pwa/astro 0.3.1
├─┬ @vite-pwa/assets-generator 0.2.4 peer
│ ├── sharp 0.32.6
│ └─┬ sharp-ico 0.1.5
│   └── sharp 0.33.4
├─┬ astro 4.8.6 peer
│ └── sharp 0.33.4
└─┬ vite-plugin-pwa 0.19.8 peer
  └─┬ @vite-pwa/assets-generator 0.2.4 peer
    ├── sharp 0.32.6
    └─┬ sharp-ico 0.1.5
      └── sharp 0.33.4
astro 4.8.6
└── sharp 0.33.4
sharp 0.33.4
sharp-ico 0.1.5
└── sharp 0.33.4
vite-plugin-pwa 0.19.8
└─┬ @vite-pwa/assets-generator 0.2.4 peer
  ├── sharp 0.32.6
  └─┬ sharp-ico 0.1.5
    └── sharp 0.33.4
@EKliptus
Copy link
Author

Oups I see a link with #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant