Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-vue): add customElement option to compiler #238

Merged
merged 16 commits into from Dec 7, 2023

Conversation

baiwusanyu-c
Copy link
Contributor

@baiwusanyu-c baiwusanyu-c commented Aug 22, 2023

Description

According to the filter result of vite-plugin-vue, the compiler like vue passes the customElement option parameter

Additional context

wait upstream vuejs/core#8989


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Co-authored-by: 三咲智子 Kevin Deng <sxzz@sxzz.moe>
@baiwusanyu-c baiwusanyu-c requested a review from sxzz August 22, 2023 07:25
@sxzz sxzz changed the title feat: added customElement option to vue compiler feat(plugin-vue): add customElement option to compiler Aug 24, 2023
@baiwusanyu-c baiwusanyu-c marked this pull request as ready for review December 6, 2023 07:17
@sxzz
Copy link
Member

sxzz commented Dec 7, 2023

Looks like CI failed.

@sxzz sxzz merged commit 99564d5 into vitejs:main Dec 7, 2023
6 checks passed
@baiwusanyu-c baiwusanyu-c deleted the bwsy/feat/customElOption branch December 7, 2023 05:21
sxzz added a commit that referenced this pull request Dec 7, 2023
Co-authored-by: 三咲智子 Kevin Deng <sxzz@sxzz.moe>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants