Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vue2 tsx (class component) hmr exception #67

Merged
merged 1 commit into from Nov 29, 2022
Merged

fix: vue2 tsx (class component) hmr exception #67

merged 1 commit into from Nov 29, 2022

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Nov 26, 2022

@sun0day
Copy link
Member Author

sun0day commented Nov 26, 2022

@sodatea cc

@sun0day sun0day changed the title fix: invalidate script module cache when it changed in hot update vue2 tsx (class component) hmr exception Nov 26, 2022
@sun0day sun0day changed the title vue2 tsx (class component) hmr exception fix: vue2 tsx (class component) hmr exception Nov 26, 2022
sodatea
sodatea requested changes Nov 29, 2022
View reviewed changes
Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't include unrelated style changes in the PR

@sun0day
Copy link
Member Author

sun0day commented Nov 29, 2022

Please don't include unrelated style changes in the PR

Done.

sodatea
sodatea approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sodatea sodatea merged commit b8e6133 into vitejs:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sodatea sodatea sodatea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue2 tsx (class component) hmr exception
2 participants
@sun0day @sodatea