Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve complier from peer dep when unable to resolve from the root #68

Merged
merged 1 commit into from Nov 29, 2022

Conversation

rorry121
Copy link
Contributor

@rorry121 rorry121 commented Nov 27, 2022

── root
  └── v2-7
    └── node_modules
    └── vite.config.ts
    └── ...
  └── src
    └── index.ts

Hello, when I excute vite build --config v2-7/vite.config.ts in root. There is no vue(2.7),but the v2-7 has. And I ran into this error:

[vite:vue2] Failed to resolve vue/compiler-sfc.
@vitejs/plugin-vue2 requires vue (>=2.7.0) to be present in the dependency tree.
error during build:
Error: Failed to resolve vue/compiler-sfc.
@vitejs/plugin-vue2 requires vue (>=2.7.0) to be present in the dependency tree.

I don't know why remove this part of the code.I think this may be a mistake. It should be the same as @vitejs/plugin-vue

@rorry121
Copy link
Contributor Author

@sodatea help

Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, either. But this change looks good to me.

@sodatea sodatea merged commit 0ea62d2 into vitejs:main Nov 29, 2022
@rorry121
Copy link
Contributor Author

@sodatea okay, looking forward to a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants