Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update for Vite 4.x support, closes @vitejs/plugin-vue2#71 #72

Merged
merged 1 commit into from Dec 10, 2022
Merged

feat: Update for Vite 4.x support, closes @vitejs/plugin-vue2#71 #72

merged 1 commit into from Dec 10, 2022

Conversation

khalwat
Copy link
Contributor

@khalwat khalwat commented Dec 9, 2022

Description

With Vite 4's released, this PR updates the peerDependencies to allow it to work with Vite 4.x (assuming no other changes are needed).

Linked Issues

Closes: #71

Additional context

@khalwat khalwat mentioned this pull request Dec 9, 2022
Closed
@khalwat
Copy link
Contributor Author

khalwat commented Dec 10, 2022

In my limited testing, I can confirm that just bumping the peerDependencies appears to work fine with Vite 4.x

sodatea
sodatea approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sodatea sodatea merged commit d2360be into vitejs:main Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sodatea sodatea sodatea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vite@4 support
2 participants
@khalwat @sodatea