Skip to content

Commit

Permalink
fix: avoid binding ClassExpression (#13572)
Browse files Browse the repository at this point in the history
  • Loading branch information
sun0day committed Jun 20, 2023
1 parent 435bacc commit 1a0c806
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
11 changes: 11 additions & 0 deletions packages/vite/src/node/ssr/__tests__/ssrTransform.spec.ts
Expand Up @@ -904,3 +904,14 @@ for (const test in tests) {
}"
`)
})

test('avoid binding ClassExpression', async () => {
const result = await ssrTransformSimple(
`import Foo, {Bar} from './foo';console.log(Foo, Bar);const obj = {foo: class Foo{}, bar: class Bar{}}`,
)
expect(result?.code).toMatchInlineSnapshot(`
"const __vite_ssr_import_0__ = await __vite_ssr_import__(\\"./foo\\");
console.log(__vite_ssr_import_0__.default, __vite_ssr_import_0__.Bar);const obj = {foo: class Foo{}, bar: class Bar{}}"
`)
})
2 changes: 1 addition & 1 deletion packages/vite/src/node/ssr/ssrTransform.ts
Expand Up @@ -256,7 +256,7 @@ async function ssrTransformScript(
const topNode = parentStack[parentStack.length - 2]
s.prependRight(topNode.start, `const ${id.name} = ${binding};\n`)
}
} else {
} else if (parent.type !== 'ClassExpression') {
s.update(id.start, id.end, binding)
}
},
Expand Down

0 comments on commit 1a0c806

Please sign in to comment.