Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove picomatch type import (fixes #10656) #10678

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 28, 2022

Description

The type script script was somehow resolving node_modules/@types in the root of monorepo and this is the reason why we didn't notice this. I've updated the tsconfig.json to detect this case.

Type import of picomatch was included in index.d.ts but was not used, because the prop that uses this type was marked as internal. (internal properties are removed from the output)

/**
* @internal
*/
_fsDenyGlob: Matcher
}

Since we don't use them, I added some codes in postPatchTypes.ts to remove that type import.

fixes #10656
superseds close #10672

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

it somehow resolved `node_modules/@types` in the root of monorepo
@sapphi-red sapphi-red added bug p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) regression The issue only appears after a new release labels Oct 28, 2022
@patak-dev patak-dev merged commit 1128b4d into vitejs:main Oct 28, 2022
@sapphi-red sapphi-red deleted the fix/remove-picomatch-type-import branch October 28, 2022 07:08
@sapphi-red sapphi-red mentioned this pull request Dec 5, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) regression The issue only appears after a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite 3.2.0 type definitions depend on picomatch
2 participants