Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix grammar in changelog #11224

Merged
merged 1 commit into from
Dec 6, 2022
Merged

docs: fix grammar in changelog #11224

merged 1 commit into from
Dec 6, 2022

Conversation

benmccann
Copy link
Collaborator

Description

Three changes to this sentence:

  • "since" should refer to an effect of the action
  • the double loading happens because "a and b" load it. "but" indicates opposition, but the two both need to happen for there to be double loading, so there's no opposition
  • use an em dash to separate example

Additional context

The rest of the changelog reads well to me


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@benmccann benmccann mentioned this pull request Dec 6, 2022
4 tasks
@patak-dev
Copy link
Member

Thanks a lot Ben! 🙏🏼

@patak-dev patak-dev merged commit f1b891f into main Dec 6, 2022
@patak-dev patak-dev deleted the benmccann-patch-2 branch December 6, 2022 16:50
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants