Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: shrink genSourceMapUrl type #11667

Merged
merged 1 commit into from
Jan 12, 2023
Merged

chore: shrink genSourceMapUrl type #11667

merged 1 commit into from
Jan 12, 2023

Conversation

chenfan0
Copy link
Contributor

Description

The genSourceMapUrl function will not receive parameters of undefined type, and it is meaningless to receive parameters of undefined type to generate sourcemap.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra context: #11541

@bluwy bluwy merged commit 9fb406b into vitejs:main Jan 12, 2023
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@chenfan0 chenfan0 deleted the chore/shrink branch June 21, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants