Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unify css collecting order #11671

Merged
merged 2 commits into from Sep 22, 2023
Merged

fix: unify css collecting order #11671

merged 2 commits into from Sep 22, 2023

Conversation

lsdsjy
Copy link
Contributor

@lsdsjy lsdsjy commented Jan 12, 2023 •
edited

Fixes #11662

Description

This PR unify the CSS collecting order whether cssCodeSplit is true or false, aligning the latter with the former.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@lsdsjy lsdsjy marked this pull request as ready for review January 12, 2023 08:30
@lsdsjy lsdsjy mentioned this pull request Jan 12, 2023
Closed
7 tasks
sapphi-red
sapphi-red reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

packages/vite/src/node/plugins/css.ts Outdated Show resolved Hide resolved
@sapphi-red sapphi-red added feat: css p3-minor-bug An edge case that only affects very specific usage (priority) labels Jul 24, 2023
@sapphi-red sapphi-red mentioned this pull request Jul 28, 2023
Merged
9 tasks
@sapphi-red sapphi-red mentioned this pull request Aug 9, 2023
Merged
9 tasks
@lsdsjy lsdsjy force-pushed the css-unsplit branch 4 times, most recently from 023be7b to 763b52a Compare August 9, 2023 09:47
sapphi-red
sapphi-red approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you!

@ronen-e
Copy link

ronen-e commented Aug 22, 2023 •
edited

I'm experiencing the css issues as well. I noticed issue #11662 and this PR while searching for solutions and I'm wondering when it will be merged and if there are existing workarounds.

@sapphi-red sapphi-red merged commit 20a8a15 into vitejs:main Sep 22, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@patak-dev patak-dev Awaiting requested review from patak-dev

@bluwy bluwy Awaiting requested review from bluwy

Assignees
No one assigned
Labels
feat: css p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent order of styles when cssCodeSplit is false
3 participants
@lsdsjy @ronen-e @sapphi-red