Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix type warning during building vite #11673

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

sapphi-red
Copy link
Member

Description

When running pnpm build in packages/vite, rollup output the following warning.

loaded rollup.config.ts with warnings
(!) Plugin typescript: @rollup/plugin-typescript TS2307: Cannot find module 'vite' or its corresponding type declarations.
src/node/__tests__/build.spec.ts: (4:29)

4 import type { Logger } from 'vite'
                              ~~~~~~

src/node/__tests__/plugins/dynamicImportVar/parse.test.ts: (3:31)

3 import { normalizePath } from 'vite'

This PR fixes this.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Jan 12, 2023
@sapphi-red sapphi-red changed the title chore: fix build type warning chore: fix type warning during building vite Jan 12, 2023
@sapphi-red sapphi-red merged commit 305b76e into vitejs:main Jan 12, 2023
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@sapphi-red sapphi-red deleted the chore/fix-build-warning branch April 20, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants