Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(legacy): fix browserslist import, close https://github.com/vitejs/vite/issues/11898 #11899

Merged
merged 1 commit into from Feb 2, 2023
Merged

fix(legacy): fix browserslist import, close https://github.com/vitejs/vite/issues/11898 #11899

merged 1 commit into from Feb 2, 2023

Conversation

ModyQyW
Copy link
Contributor

@ModyQyW ModyQyW commented Feb 2, 2023 •
edited

Description

browserslist is a CommonJS module. We can't use named import.

This bug is introduced by d5b8f86#diff-ab75c34fa418085884af97e74c9166830b9f0a3456f9d3336e0c075d6ae9b05aR26.

This PR fixes the import.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ModyQyW ModyQyW mentioned this pull request Feb 2, 2023
Closed
7 tasks
@ModyQyW ModyQyW changed the title fix: fix browserslist import, close https://github.com/vitejs/vite/issues/11898 fix(legacy): fix browserslist import, close https://github.com/vitejs/vite/issues/11898 Feb 2, 2023
sapphi-red
sapphi-red approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, thanks!

@sapphi-red sapphi-red added plugin: legacy p5-urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) regression The issue only appears after a new release labels Feb 2, 2023
@patak-dev patak-dev merged commit 9241d08 into vitejs:main Feb 2, 2023
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@ModyQyW @futurGH
fix(legacy): fix browserslist import, close vitejs#11898 (vitejs#11899)
a14faa4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
p5-urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) plugin: legacy regression The issue only appears after a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ModyQyW @sapphi-red @patak-dev