refactor: esbuild plugin config logic #12493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
patak-dev
commented
Mar 20, 2023
Comment on lines
-174
to
-176
| delete resolvedOptions.include | ||
| delete resolvedOptions.exclude | ||
| delete resolvedOptions.jsxInject |
There was a problem hiding this comment.
These were needed because there is a cast here: https://github.com/vitejs/vite/pull/12493/files#diff-6d149ac9706cd508b52db0c059a0f01d670620a9a5a73cd7b122ce62b6b69471R205, from our own extended options. These fields are no longer present when calling transformWithEsbuild after the changes in this PR.
sapphi-red
approved these changes
Mar 21, 2023
bluwy
approved these changes
Mar 21, 2023
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
|
@sapphi-red here is the run against the merged commit: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/4481055968 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify the config logic of the
vite:esbuild. It should also be a bit more performant, but it is too small to mark this as a perf PR. Avoiding changing the shape of the config throughdeletes could help though.What is the purpose of this pull request?