-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more file ops support. eg.add/revome... #126
Comments
A new file created is typically empty, triggering updates for this doesn't really mean much. Triggering update on file removal has a good chance of instantly cause an error, so it's better for the user to manually reload in this case. Open for suggestions if we have more concrete cases where such updates are needed. |
Thanks your explaination.I am sorry with I don't say my idea clearly. For the sence of add file,eg. For the sence of delete file.The user don`t get error on now.Because the deleted file isn't be watced with delete event and isn't trrigger hmr. Actuary, the user need judge this sence with why the deleted sth. is still on page.Reload will be correct way for the user.Maybe we can watch delete file and trrigger hmr with reload, it can let user to saw the error instead of they judgement slef.For the best hmr, the deleted file may be isn't import by the app,it is import someone of component,should not reload whole page.so this is maybe need some work todo. |
Hmr only watch file change,not watch other file ops.It is necessary for hmr.
The text was updated successfully, but these errors were encountered: