fix: fix build for dynamic load postcss plugin #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Look like it is a weak dep shim....Why not use |
|
The rollup build also bundles most of the dependencies so |
yyx990803
approved these changes
Jan 2, 2021
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Jan 2, 2021
fix vitejs#1287 Co-authored-by: Evan You <yyx990803@gmail.com>
yyx990803
reviewed
Jan 3, 2021
| @@ -123,8 +123,12 @@ const nodeConfig = { | |||
| replacement: `eval('require')('sugarss')` | |||
| }, | |||
| 'import-fresh/index.js': { | |||
| src: 'require(filePath)', | |||
| pattern: /require\(filePath\)/g, | |||
There was a problem hiding this comment.
This change was unnecessary and caused #1306
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1287