Optimize a dependency aliased to an absolute path

[aleclarson]

I need to optimize react since it uses CommonJS modules, but I also need to force all packages to use the same copy of React, which I accomplish via the alias option in my Vite config. Unfortunately, these two needs are in conflict, as the import rewriter doesn't check if an absolute path is optimized.

[aleclarson]

I also need to force all packages to use the same copy of React

For more context, my project is linked to local clones of packages that also depend on React.

[aleclarson]

Perhaps, instead of using alias, it would be easier (from Vite's perspective) to use a load hook for the redirection.

edit: Hmm, I don't think this is a viable workaround, as the optimizer has already duplicated React by the time my load hook runs. And there's no way to inject a load hook into the optimizer.

[yyx990803]

I think we can add a dedupe option to force react to always be resolved using your project root as basedir?

[aleclarson]

Sounds good to me. I was about to make a plugin for it, but built-in is better in this case.

[yyx990803]

Wait, if a dependency is optimized it already always uses the optimized version without the need for an alias.

[aleclarson]

The optimizer is duplicating React for me. I'll make a repro.

[aleclarson]

Repro: https://github.com/aleclarson/vite-sandbox/tree/issue-1302

[aleclarson]

My current workaround: https://github.com/alloc/vite-plugin-dedupe