Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(html): support image set in inline style #13473

Merged
merged 1 commit into from Jun 9, 2023
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jun 9, 2023

Description

Continuation from #13059, support image-set in inline style="..." too. The handling is already in place for url(...), so it was a matter of updating the checks to detect image-set(...) too.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added feat: css p2-nice-to-have Not breaking anything but nice to have (priority) labels Jun 9, 2023
@stackblitz
Copy link

stackblitz bot commented Jun 9, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit 2c0faba into main Jun 9, 2023
13 checks passed
@patak-dev patak-dev deleted the image-set-inline-style branch June 9, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants