optimizeDeps.entries doesn't work when it's inside node_modules but not inside any packages

[Jinjiang]

Describe the bug

I have an entry file that needs to be specified manually. After upgrading to 4.4.2 it doesn't work.

Reproduction

https://github.com/Jinjiang/reproductions/tree/vite-optimize-deps-entries-20230711

Steps to reproduce

How to reproduce:

pnpm install
pnpm dev

Then uncomment the line 2 in main.js and save the file. The error will be thrown in browser console.

Uncaught SyntaxError: The requested module '/node_modules/foo/index.js?v=2366fb81' does not provide an export named 'foo'

With vite@4.4.0-beta.0 it works.

System Info

System:
    OS: macOS 14.0
    CPU: (8) arm64 Apple M1
    Memory: 60.47 MB / 8.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 16.15.0 - ~/.asdf/installs/nodejs/16.15.0/bin/node
    Yarn: 1.22.19 - ~/.asdf/shims/yarn
    npm: 8.5.5 - ~/.asdf/plugins/nodejs/shims/npm
    pnpm: 8.5.1 - ~/Library/pnpm/pnpm
  Browsers:
    Safari: 17.0
  npmPackages:
    vite: 4.4.2 => 4.4.2

Used Package Manager

pnpm

Logs

Uncaught SyntaxError: The requested module '/node_modules/foo/index.js?v=2366fb81' does not provide an export named 'foo'

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[patak-dev]

It looks like you were relying on a bug in fast-glob. Negative patterns didn't affect hidden files before 3.3.0. It was fixed here:

• Weird behavior with ignore pattern and **/* mrmlnc/fast-glob#343

Entries inside node_modules should have never worked in Vite, the feature was always intended to get entries from the user source code. We didn't have need for this before, so if there is a way to restructure things in your project I think it would be better to avoid adding complexity on Vite's side.

[Jinjiang]

@patak-dev Understood. I think I already found some walkarounds in my project. Thanks for the information!