fix: display manualChunks warning only when a function is not used (#13797) #13798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jafin
changed the title
…rm` warning only when a function is not used. (vitejs#13797)
jafin
force-pushed
the
fix/manualChunks-warning
branch
from
5b203e8
to
6aad23b
Compare
jafin
commented
Jul 12, 2023
| // else, leave the object form of manualChunks untouched, as | ||
| // we can't safely replicate rollup handling. | ||
| // eslint-disable-next-line no-console | ||
| console.warn( |
There was a problem hiding this comment.
Unrelated to root change, just flagging, is there some global logger to log warnings vs using console.warn?
There was a problem hiding this comment.
Good catch. Yes there is a logger but it's only available in configResolved: resolvedConfig.logger.warn(...). I guess we can use a variable to track this and log it out in the configResolved hook instead.
|
There is also typo in message. |
- changed to correct location build.rollupOptions.output.manualChunks
Updated with change. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Error logged to console when using manualChunkSplitting and function is used (fix #13797)
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).