Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0 Beta] Bring back env and mode in config #1380

Closed
AlexandreBonaventure opened this issue Jan 5, 2021 · 2 comments
Closed

[2.0 Beta] Bring back env and mode in config #1380

AlexandreBonaventure opened this issue Jan 5, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@AlexandreBonaventure
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Migrating from v1, I realized env + mode options in config are gone in v2.

Describe the solution you'd like
Not sure about the reasoning here, but we've found these options to be very helpful. We share common configuration between different projects in a monorepo, and the ability to override these in the config allows more flexibilty for us, and let us handle it in a more programmatic fashion (rather than creating env files). It can probably be reimplemented through a custom user plugin but that would mean reimplementing the define plugin.

@aleclarson aleclarson added the enhancement New feature or request label Jan 5, 2021
@AlexandreBonaventure
Copy link
Contributor Author

happy to submit a PR btw

@yyx990803
Copy link
Member

396bbf8 allows mode to be specified via user config.

As of beta.10 you can also directly set process.env.VITE_FOO = 'hi' in the config file.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants