Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: constrain inject helpers for iife #13909

Merged
merged 1 commit into from Jul 21, 2023
Merged

fix: constrain inject helpers for iife #13909

merged 1 commit into from Jul 21, 2023

Conversation

patak-dev
Copy link
Member

Fixes #13907

Description

Also tested with #11641

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@stackblitz
Copy link

stackblitz bot commented Jul 20, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

bluwy
bluwy approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a test too 😄

@patak-dev
Copy link
Member Author

I'll send another PR with the tests, I would like to include this one in the next patch.

@patak-dev patak-dev merged commit c89f677 into main Jul 21, 2023
20 checks passed
@patak-dev patak-dev deleted the fix/inject-helpers-iife-re branch July 21, 2023 07:59
@patak-dev patak-dev mentioned this pull request Jul 21, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vite build lose some code with special npm package
2 participants
@patak-dev @bluwy